Skip to content

Conversation

rtaupe
Copy link
Collaborator

@rtaupe rtaupe commented Apr 22, 2020

Move SubstitutionTest and UnifierTest to common package because Substitution and Unifier are also in common package. Move also two static methods from NaiveGrounder to a new class SubstitutionTestUtil because those methods are only used by tests.

rtaupe added 2 commits April 22, 2020 11:13
because tested classes are also in common package
because tested classes are also in common package
@rtaupe rtaupe marked this pull request as draft April 22, 2020 09:20
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #247      +/-   ##
============================================
- Coverage     76.83%   76.78%   -0.05%     
+ Complexity     2056     2051       -5     
============================================
  Files           150      150              
  Lines          6782     6764      -18     
  Branches       1184     1180       -4     
============================================
- Hits           5211     5194      -17     
  Misses         1177     1177              
+ Partials        394      393       -1     
Impacted Files Coverage Δ Complexity Δ
.../at/ac/tuwien/kr/alpha/grounder/NaiveGrounder.java 87.46% <ø> (-0.37%) 101.00 <0.00> (-5.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2239eb3...b3484a0. Read the comment docs.

@rtaupe rtaupe requested a review from madmike200590 April 22, 2020 09:58
@rtaupe rtaupe marked this pull request as ready for review April 22, 2020 09:58
@madmike200590 madmike200590 merged commit 8b01f9b into master Apr 23, 2020
@madmike200590 madmike200590 deleted the move_substitution_test branch April 23, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants