Merge pull request #362 from alphagov/fix-integer-auto-id-error

Fix integer auto id error

backdrop/core/records.py

@@ -55,7 +55,7 @@ def _generate_auto_id(record, auto_id_keys):
                 ', '.join(missing_keys)))
 
     return b64encode('.'.join(
-        record[key] for key in auto_id_keys))
+        str(record[key]) for key in auto_id_keys))
 
 
 def parse_timestamp(record):

tests/core/test_records.py

@@ -0,0 +1,20 @@
+from unittest import TestCase
+from hamcrest import assert_that, is_
+from nose.tools import assert_raises
+from backdrop.core.records import _generate_auto_id
+from backdrop.core.errors import ValidationError
+
+
+class TestRecords(TestCase):
+    def test__generate_auto_id_generates_auto_ids_correctly_for_standard_case(self):
+        assert_that(_generate_auto_id({'foo': 'foo'}, ['foo']), is_('Zm9v'))
+
+    def test__generate_auto_id_generates_auto_ids_correctly_for_integers(self):
+        assert_that(_generate_auto_id({'foo': 1, 'bar': 'foo'}, ['foo', 'bar']), is_('MS5mb28='))
+
+    def test__generate_auto_id_throws_error_when_key_not_matched(self):
+        assert_raises(
+            ValidationError,
+            _generate_auto_id,
+            {'foo': 1},
+            ['bar'])