Fix working with end-to-end tests #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't ideal as none of these tests do much with Email Alert Service, but similarly a change to this application can break the full test suite.
This is to allow the creation of the queues that are part of the rabbitmq config file. This is primarily used by end-to-end tests as a means to set up the environment so tests can run. Incidentally, it appears the queue configurations in the rabbitmq config file are not used by anything besides this so could probably just be hardcoded here and removed from that file. I wanted to minimise changes though so I avoided that step.
The bin/email_alert_service file is deprecated so this runs the main process by default.
edwardkerry
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/odtNdsay/574-e2e-tests-failing-since-monday-morning
This adds a few changes that aim to resolve problems running the end-to-end tests.
This depends on alphagov/publishing-e2e-tests#326 and the end-to-end test result here is based on that.
This firstly makes this repo run the end-to-end tests as part of it's build so that it is harder for this app to break the build. This is a slightly annoying situation as the end-to-end tests aren't actually being tested but apps (Content Tagger) do break without them.
This then adds a rake task to create the RabbitMQ queues that are used by this app. I'm not sure whether these were used / worked before.
Finally this updates the dockerfile to reflect the deprecation of the bin/email_alert_service command.