Fix unlabelled nav on licence transaction pages #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthillco
changed the title
KludgeKML
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
eac417f
to
e789c44
Compare
KludgeKML
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
e789c44
to
71968be
Compare
KludgeKML
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
71968be
to
fc6aac3
Compare
matthillco
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
fc6aac3
to
1f7e5b8
Compare
matthillco
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
1f7e5b8
to
f7c7127
Compare
matthillco
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
f7c7127
to
54f00b8
Compare
KludgeKML
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
d9ec851
to
e17ceb4
Compare
- remove yield blocks from layouts - add component into shared partial - add helper method to make contents list data Co-authored-by: Matt Hill <matt.hill@digital.cabinet-office.gov.uk>
matthillco
force-pushed
the
unlabeled-nav-on-licence-places
branch
from
e17ceb4
to
3f0dd82
Compare
georges1996
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The navigation underneath the H1 doesn’t have a label. Trello card
Why
When there are more than 1 nav elements, labelling them helps screen reader users to understand their purpose more quickly.
How
Replaces the navigation block with a
contents_listcomponent.Screenshots?
BEFORE
AFTER