Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'base' import from files in core and overrides layers #2455

Merged
merged 3 commits into from
Dec 6, 2021

Conversation

36degrees
Copy link
Contributor

Importing files from these layers without first importing the 'base' file was deprecated in #1807. Anyone who was relying on these imports should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first.

This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS.

We can also remove the tests from both layers, which were only checking that the deprecation warning was emitted as expected.

Closes #1800.

Importing files from this layer without first importing the 'base' file was deprecated in #1807. Anyone who was relying on the import should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first.

This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS.

Remove the tests, which were only checking that the deprecation warning was emitted as expected.
Importing files from this layer without first importing the 'base' file was deprecated in #1807. Anyone who was relying on the import should already be seeing warnings. If this change affects them, they'll just need to ensure they're importing the base layer first.

This is part of a change to the way that the base layers (settings, tools and helpers) are imported within different parts of GOV.UK Frontend’s Sass, designed to reduce the time it takes to compile the Sass to CSS.

Remove the tests, which were only checking that the deprecation warning was emitted as expected.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2455 December 2, 2021 17:43 Inactive
@36degrees
Copy link
Contributor Author

Still needs a changelog entry.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2455 December 3, 2021 09:58 Inactive
@36degrees
Copy link
Contributor Author

Happy for this to be merged if @EoinShaughnessy is happy with the release notes.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@EoinShaughnessy EoinShaughnessy changed the title Remove 'base' import from files in core and overrides layers Remove 'base' import from files in core and overrides layers Dec 6, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@EoinShaughnessy EoinShaughnessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content looks good! Just a couple of small suggestions and a question.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2455 December 6, 2021 16:11 Inactive
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-2455 December 6, 2021 16:42 Inactive
@vanitabarrett vanitabarrett merged commit 873cc06 into main Dec 6, 2021
@vanitabarrett vanitabarrett deleted the remove-base-imports branch December 6, 2021 17:00
@vanitabarrett vanitabarrett mentioned this pull request Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency imports from files in the core and overrides layers
4 participants