Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the types group across 1 directory with 2 updates #5022

Merged
merged 2 commits into from
May 30, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 30, 2024

Bumps the types group with 2 updates in the / directory: @octokit/rest and @types/node.

Updates @octokit/rest from 20.0.2 to 20.1.1

Release notes

Sourced from @​octokit/rest's releases.

v20.1.1

20.1.1 (2024-05-03)

Bug Fixes

v20.1.0

20.1.0 (2024-04-03)

Features

Commits
  • 7058346 fix: update REST endpoints (#428)
  • b4e2102 ci(action): update actions/checkout digest to 0ad4b8f (#426)
  • 9d99a65 ci(action): update actions/checkout digest to 1d96c77 (#425)
  • c751cb5 ci(action): update actions/add-to-project action to v1.0.1 (#424)
  • 792bb39 chore(deps): update dependency undici to v6.11.1 [security] (#421)
  • 9adf1a4 feat(security): Add provenance (#420)
  • 9ab9253 ci(action): update actions/add-to-project action to v1
  • 335f2d2 ci(action): update actions/add-to-project action to v0.6.1 (#418)
  • 8f0efe0 build(deps-dev): Bump follow-redirects from 1.15.4 to 1.15.6 (#416)
  • 5bf5fa6 build(deps-dev): Bump follow-redirects from 1.15.4 to 1.15.6 in /docs (#415)
  • Additional commits viewable in compare view

Updates @types/node from 20.11.30 to 20.12.13

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
  • @dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
  • @dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
  • @dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
  • @dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the types group with 2 updates in the / directory: [@octokit/rest](https://github.com/octokit/rest.js) and [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node).


Updates `@octokit/rest` from 20.0.2 to 20.1.1
- [Release notes](https://github.com/octokit/rest.js/releases)
- [Commits](octokit/rest.js@v20.0.2...v20.1.1)

Updates `@types/node` from 20.11.30 to 20.12.13
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@octokit/rest"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: types
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: types
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript labels May 30, 2024
@dependabot dependabot bot requested a review from a team May 30, 2024 15:13
Copy link

github-actions bot commented May 30, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.37 KiB
dist/govuk-frontend-development.min.js 42.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 88.16 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.83 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.36 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.33 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 78.45 KiB 40.31 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 261df4b

Fixes a type issue introduced in `@types/node 20.12.11` [1]:

```
node_modules/path-scurry/dist/cjs/index.d.ts:117:31 - error TS2720: Class 'PathBase' incorrectly implements class 'Dirent'. Did you mean to extend 'Dirent' and inherit its members as a subclass?
  Property 'parentPath' is missing in type 'PathBase' but required in type 'Dirent'.

117 export declare abstract class PathBase implements Dirent {
                                  ~~~~~~~~

  node_modules/@types/node/fs.d.ts:247:9
    247         parentPath: string;
                ~~~~~~~~~~
    'parentPath' is declared here.
```

Bump glob, which includes path-scurry as a dependency:

```
$ npm ls path-scurry
@govuk-frontend/repository@ /Users/oliver.byford/Code/govuk-frontend
└─┬ @govuk-frontend/lib@ -> ./shared/lib
  └─┬ glob@10.3.10
    └── path-scurry@1.10.1
```

[1]: isaacs/path-scurry#18
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5022 May 30, 2024 15:29 Inactive
Copy link
Member

@romaricpascal romaricpascal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my blunder fixing conflicts in #5005, cherry picked @36degrees's bump of glob that fixes the tests, looks all good to merge ⛵

@romaricpascal romaricpascal merged commit f03734f into main May 30, 2024
48 checks passed
@romaricpascal romaricpascal deleted the dependabot/npm_and_yarn/types-36dd59fd1d branch May 30, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants