Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update back link template tests to use jsdom #5026

Merged
merged 6 commits into from
Jun 10, 2024

Conversation

36degrees
Copy link
Contributor

Plus some tidying up of the existing tests and a couple of simplifications of the template – see individual commits for details.

Part of #5010.

The next commit will refactor the tests to make use of jsdom which requires us to update the filename so that we get the jsdom test environment.

Doing this in two commits so that git shows the changes to the file rather than treating it as an addition and a deletion.
Copy link

github-actions bot commented May 31, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.37 KiB
dist/govuk-frontend-development.min.js 42.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 88.16 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.83 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.36 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.33 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 78.45 KiB 40.31 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 33a613a

Copy link

github-actions bot commented May 31, 2024

Other changes to npm package

The diff could not be posted as a comment. You can download it from the workflow artifacts.


Action run for 33a613a

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocker. Approving now so you can just merge it©️ when you wanna.

The template already uses a default href of ‘#’ if no href is provided, which we want to test – passing ‘#’ as an option defeats the point of the test.
There’s already an expectation for the default text of ‘Back’ in the ‘renders the default example with an anchor, href and text correctly’ test.

The template has no option for inverse colours – the example just passes an additional class, so the test has no value over the existing test for additional classes.
@36degrees 36degrees force-pushed the jsdom-back-link-template-tests branch from af3de3e to 33a613a Compare June 10, 2024 15:26
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5026 June 10, 2024 15:26 Inactive
@36degrees 36degrees requested a review from owenatgov June 10, 2024 15:26
Copy link

Rendered HTML changes to npm package

diff --git a/packages/govuk-frontend/dist/govuk/components/back-link/template-with-custom-link.html b/packages/govuk-frontend/dist/govuk/components/back-link/template-with-custom-link.html
new file mode 100644
index 000000000..9ffb06ea9
--- /dev/null
+++ b/packages/govuk-frontend/dist/govuk/components/back-link/template-with-custom-link.html
@@ -0,0 +1 @@
+<a href="/home" class="govuk-back-link">Back to home</a>

Action run for 33a613a

@36degrees 36degrees merged commit 771d8ac into main Jun 10, 2024
48 checks passed
@36degrees 36degrees deleted the jsdom-back-link-template-tests branch June 10, 2024 15:32
domoscargin pushed a commit that referenced this pull request Jun 19, 2024
Update back link template tests to use jsdom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants