Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task list template tests to use jsdom #5045

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

36degrees
Copy link
Contributor

Also refactor the tests to minimise the number of times we have to render a given example.

This means for example that all of the tests relating to setting html vs text are now grouped; all the examples that relate to setting custom classes are grouped.

Part of #5010

The next commit will refactor the tests to make use of jsdom which requires us to update the filename so that we get the jsdom test environment.

Doing this in two commits so that git shows the changes to the file rather than treating it as an addition and a deletion.
Also refactor the tests to minimise the number of times we have to render a given example.

This means for example that all of the tests relating to setting `html` vs `text` are now grouped; all the examples that relate to setting custom classes are grouped.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5045 June 5, 2024 15:05 Inactive
Copy link

github-actions bot commented Jun 5, 2024

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 113.37 KiB
dist/govuk-frontend-development.min.js 42.34 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 88.16 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 82.83 KiB
packages/govuk-frontend/dist/govuk/all.mjs 981 B
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 359 B
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 113.36 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.33 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 4.86 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 78.45 KiB 40.31 KiB
accordion.mjs 22.71 KiB 12.85 KiB
button.mjs 5.98 KiB 2.69 KiB
character-count.mjs 22.4 KiB 9.92 KiB
checkboxes.mjs 5.83 KiB 2.83 KiB
error-summary.mjs 7.89 KiB 3.46 KiB
exit-this-page.mjs 17.1 KiB 9.26 KiB
header.mjs 4.46 KiB 2.6 KiB
notification-banner.mjs 6.26 KiB 2.62 KiB
password-input.mjs 15.15 KiB 7.25 KiB
radios.mjs 4.83 KiB 2.38 KiB
skip-link.mjs 4.39 KiB 2.18 KiB
tabs.mjs 10.13 KiB 6.11 KiB

View stats and visualisations on the review app


Action run for 2532e64

@romaricpascal romaricpascal merged commit a696309 into main Jul 18, 2024
49 checks passed
@romaricpascal romaricpascal deleted the jsdom-task-list-template-tests branch July 18, 2024 13:44
querkmachine pushed a commit that referenced this pull request Aug 19, 2024
Update task list template tests to use jsdom
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants