-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Safari 10.1 to Safari 11 in Grade C browser example #5082
Conversation
📋 StatsFile sizes
Modules
View stats and visualisations on the review app Action run for 1099d1c |
The problem is we've defined Grade C as everything not in A or B that supports Because the |
Truuuuue. I suppose Safari 10.1 is just an annoying special case. From our perspective, it's JS enabled but subsequently has everything turned off (including "necessary enhancements"), whereas from a user perspective it just doesn't appear to run JS at all. I still think the documentation is a little confusing as-is, as the Grade C section appears to list Safari 11 as the minimum version that's in Grade C, contrary to the summary at the top of the page. It tripped me up, at least! |
I wonder if we should add some kind of link to documentation in this error message:
But not sure how many people who get into this specific case will be checking the console. As for the documentation, maybe we can add a "special cases" heading or something in the Grade C section so that it's clearer there's some niche case? |
Thinking the issue might be with the definition of what we're supporting. We document that we run in browsers that support Maybe with either:
|
I like the second option for simplicity. Then we could simplify the Grade C section documentation as well: Grade CThis grade covers browsers not in Grade A or B which fully support <script type="module">. These are:
|
Coincidentally, this was brought up on support today. It was questioned why the Frontend Docs currently state Safari 10.3 as the minimum supported version when Safari 10.3 appears to behave the same as 10.1 — JS is loaded but no components are initialised. (Indeed, Safari 10.3 also does not appear to support In my mind, bumping the 'headline' version of Safari supported in Grade C to 11.0 would make the documentation easier to understand at a glance. 10.1–10.3 can be in the footnote. I'll update my suggested edits shortly. |
The summary of browser grades include Safari 10.1 (macOS) and 10.3 (iOS) as examples of Grade C browsers. However in the Grade C section of the document it's mentioned that Safari 10.1 will not run our JavaScript as (although it technically supports `type="module"`) it fails the prerequisite support tests present in Frontend. That section lists Safari 11 (macOS) as being the minimum for Grade C instead. This is confusing, as different parts of the document use different Safari versions as the minimum supported version for Grade C. It also does not mention that Safari 10.3 (iOS) is subject to the same issues as Safari 10.1 (macOS). This commit updates the summary at the top of the document and in the Grade C section to use Safari 11 as the minimum supported version, as this is what appears to be the case to a person quickly glancing at the document in reference. The Grade C section has been updated to make it clear that, while Safari 10.1 (macOS) and Safari 10.3 (iOS) are technically included, they do not actually initialise any of Frontend's components due to failing other prerequisites outside of having support for modules.
f4913af
to
1099d1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to merge for me. Let's make sure we co-ordinate with the merge of the same change on the frontend docs so we don't have two different wordings in different places.
The summary of browser grades include Safari 10.1 (macOS) and 10.3 (iOS) as examples of Grade C browsers.
However in the Grade C section of the document it's mentioned that Safari 10.1 will not run our JavaScript as (although it technically supports
type="module"
) it fails the prerequisite support tests present in Frontend. That section also (confusingly) lists Safari 11 (macOS) as being the minimum for Grade C, not 10.1.This is confusing, as different parts of the document use different Safari versions as the minimum supported version for Grade C. It also does not mention that Safari 10.3 (iOS) is subject to the same issues as Safari 10.1 (macOS).
Changes
nomodule
, and consequentially will not run any Frontend component JavaScript.Thoughts
Are there other browsers that support modules but not
nomodule
? Maybe there's room for a Grade D in here... 🤔