Fix I18n::MissingTranslationData exception for checkbox 'none' option #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been a problem since #2005, but it only came to light after a production deployment. Checkbox questions have an implicit 'none' response if the user doesn't select any of the checkboxes. `CheckboxQuestionPresenter#response_labels` translates the options for display in the 'Previous answers' section at the bottom of the page. When the translation fallbacks were removed in #2005, a `I18n::MissingTranslationData` was being raised when the user did not select any checkboxes. Unfortunately, this commit [1] added a translation for the 'none' option even though the `CheckboxSampleFlow` [2] didn't have an explicit `:none` option. Note also that the `assert_page_has_content` was changed to check for 'None' instead of 'none'. In this commit, I've removed the translation for the 'none' option which gave me a failing test which replicated the problem we'd seen in production. I've fixed the failing test by adding an `if/else` statement to `CheckboxQuestionPresenter#response_labels` which effectively reintroduces the translation fallback in this very specific case. I'm not totally happy with this solution, but hopefully it'll do for now. [1]: f50ec82 [2]: https://github.com/alphagov/smart-answers/blob/master/test/fixtures/smart_answer_flows/checkbox-sample.rb
|
Looks good to me. |
floehopper
added a commit
that referenced
this pull request
Oct 15, 2015
…heckbox-question-none-option Fix I18n::MissingTranslationData exception for checkbox 'none' option
floehopper
deleted the
fix-missing-translations-for-checkbox-question-none-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been a problem since #2005, but it only came to light after a
production deployment. Here are couple of examples of the exceptions
we saw:
Checkbox questions have an implicit 'none' response if the user doesn't select
any of the checkboxes.
CheckboxQuestionPresenter#response_labelstranslatesthe options for display in the 'Previous answers' section at the bottom of the
page.
When the translation fallbacks were removed in #2005, a
I18n::MissingTranslationDatawas being raised when the user did not selectany checkboxes.
Unfortunately, this commit added a translation for the 'none' option even
though the
CheckboxSampleFlowdidn't have an explicit:noneoption.Note also that the
assert_page_has_contentwas changed to check for 'None'instead of 'none'.
In this commit, I've removed the translation for the 'none' option which gave
me a failing test which replicated the problem we'd seen in production.
I've fixed the failing test by adding an
if/elsestatement toCheckboxQuestionPresenter#response_labelswhich effectively reintroducesthe translation fallback in this very specific case.
I'm not totally happy with this solution, but hopefully it'll do for now.
You can see that the problem is fixed by visiting these two example URLs:
There should be no exception and you should see "none" in the previous answers.