Move global variables to Services module #2025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
floehopper
force-pushed
the
move-global-variables-to-services-module
branch
from
efa1b46
to
13fc6a2
Compare
|
I've rebased this against master and force-pushed in preparation for merging. |
floehopper
added a commit
that referenced
this pull request
Oct 21, 2015
…ces-module Move global variables to Services module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User-visible changes
None
Motivation
The
Servicesmodule was added relatively recently in commit 34f8f7f. This introduced a different way to "lookup" clients to external APIs. I'm not sure whether there's an official GDS way to do this, but this new way seems a bit better than using global variables. The main thing is that we should only do this one way which is what this PR addresses.Technical details
Hopefully this is fairly obvious from the diffs.