Remove unused code dealing with unaccepted_responses #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
These unaccepted_responses were only used by Smartdown flows, and we removed the final parts of Smartdown in d2138cd. There's definitely more code that can be removed now that Smartdown has gone but I figured I'd do this as I recently came across it.
chrisroos
force-pushed
the
remove-unused-code-for-unaccepted-responses
branch
from
a42ea4e
to
f9ead59
Compare
|
Rebased and force pushed ready for merging. |
chrisroos
added a commit
that referenced
this pull request
Nov 11, 2015
…ted-responses Remove unused code dealing with unaccepted_responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These unaccepted_responses were only used by Smartdown flows, and we removed the
final parts of Smartdown in d2138cd.
There's definitely more code that can be removed now that Smartdown has gone but
I figured I'd do this as I recently came across it.
Expected observable changes