Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Markdown preview #21

Closed
benilovj opened this issue Apr 8, 2016 · 3 comments
Closed

[CLOSED] Markdown preview #21

benilovj opened this issue Apr 8, 2016 · 3 comments

Comments

@benilovj
Copy link
Contributor

benilovj commented Apr 8, 2016

Issue by bestie
Monday 03 March 2014 at 11:12 GMT
Originally opened as #21


Preview can be generated by page refresh which saves the document or by XHR when javascript enabled.


bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/21/commits

@benilovj
Copy link
Contributor Author

benilovj commented Apr 8, 2016

Comment by elliotcm
Monday 03 March 2014 at 15:35 GMT


We built a thing to help with cleanly initializing JavaScript: https://github.com/alphagov/whitehall/blob/master/docs/javascript.md

@benilovj
Copy link
Contributor Author

benilovj commented Apr 8, 2016

Comment by heathd
Monday 03 March 2014 at 15:51 GMT


Elliot, given that that javascript initialisation stuff is only in the whitehall codebase (rather than in govuk_frontend_toolkit for example), it seems reasonable to just go for a simple, self-contained approach to initialisation for now. What do you think?

@benilovj
Copy link
Contributor Author

benilovj commented Apr 8, 2016

Comment by elliotcm
Monday 03 March 2014 at 15:55 GMT


@heathd It would be nice to start spreading that now rather than later, but it's not a dealbreaker for me.

@benilovj benilovj closed this as completed Apr 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant