Skip to content
This repository was archived by the owner on Feb 12, 2020. It is now read-only.

Conversation

irina060981
Copy link
Member

@irina060981 irina060981 commented Sep 6, 2018

For the #170

  1. remove the "Using Language" link
  2. sync override language checkbox through all lookup components
  3. fix styles for checkbox label

@coveralls
Copy link

coveralls commented Sep 6, 2018

Pull Request Test Coverage Report for Build 1783

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 242 unchanged lines in 15 files lost coverage.
  • Overall coverage decreased (-10.1%) to 43.879%

Files with Coverage Reduction New Missed Lines %
src/lib/options/storage-adapter.js 3 100.0%
src/lib/l10n/message.js 3 100.0%
src/lib/selection/media/html-selector.js 4 3.14%
src/lib/queries/lexical-query-lookup.js 4 100.0%
src/lib/l10n/l10n.js 5 100.0%
src/vue-components/lookup.vue 6 87.25%
src/lib/log/logger.js 6 100.0%
src/lib/options/options-item.js 7 93.44%
src/lib/selection/media/media-selector.js 7 100.0%
src/lib/selection/text-selector.js 9 100.0%
Totals Coverage Status
Change from base Build 1776: -10.1%
Covered Lines: 551
Relevant Lines: 1246

💛 - Coveralls

Copy link
Member

@kirlat kirlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Member

@balmas balmas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@irina060981 irina060981 merged commit 6f038c0 into master Sep 7, 2018
@irina060981 irina060981 deleted the lookup-issue#170 branch September 7, 2018 02:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants