This repository was archived by the owner on Feb 12, 2020. It is now read-only.
Toolbar position fix #533
Merged
Toolbar position fix #533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dist/alpheios-components.js.map # dist/alpheios-components.min.js # dist/style/style.css.map
Pull Request Test Coverage Report for Build 2979
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched to setting initial position of a toolbar in various units (as opposed to pixels only as before) we've lost an ability to calculate in what side of the screen the toolbar is located properly. This feature is needed to decide on what side of a toolbar tooltips and lookup panel shall be displayed.
Here is a fix.