Add tabs to options panel #709
Conversation
src/vue/components/options.vue
Outdated
| <ui-settings :key="uiSettingsKey" v-show="currentTab === 1"></ui-settings> | ||
| <feature-settings :key="featureSettingsKey" v-show="currentTab === 2"></feature-settings> | ||
| <resource-settings :key="resourceSettingsKey" v-show="currentTab === 3"></resource-settings> | ||
| <div> |
There was a problem hiding this comment.
Can we put a little divider line or something above the Reset All button to make it clearer that it Resets ALL options, not just the set being viewed? (Alternatively, we could change the functionality to have it reset only the specific set...)
There was a problem hiding this comment.
I suggest to do it this way:
There was a problem hiding this comment.
ok, but can we move the button back to the left and put the text in () ? Thanks!
There was a problem hiding this comment.
Then it would be this way
| <div class="alpheios-tab-options-switch--item" :class="{ 'alpheios-active': currentTab === 1 }" @click="currentTab = 1">U</div> | ||
| <div class="alpheios-tab-options-switch--item" :class="{ 'alpheios-active': currentTab === 2 }" @click="currentTab = 2">F</div> | ||
| <div class="alpheios-tab-options-switch--item" :class="{ 'alpheios-active': currentTab === 3 }" @click="currentTab = 3">R</div> | ||
| </div> |
There was a problem hiding this comment.
what do you think about adding a hint just above the U/F/R buttons which says "Select an option set ('U' for user interface options, 'F' for feature options and 'R' for resource options):" ?
There was a problem hiding this comment.
Sorry, Bridget! I have forgotten about this!
Fixed.
There was a problem hiding this comment.
ok, but if we're going to do it as tooltips instead of a hint, let's change the wording of the toolips to just "User Interface Options", "Feature Options" and "Resource Options". I am not sure if a hint isn't needed still, but let's see what Monica says when she tests. Thanks!
There was a problem hiding this comment.
Bridget, may be I didn't understand you properly ...
What is a hint?
Could you show me an example in some other place on a panel or popup?
There was a problem hiding this comment.
well, this is a good point -- because we don't really use hints elsewhere in the interface (and where we've had them, as in the texts interface, Harry keeps asking me to take them out...). So let's just stick with the tooltips for now, rewording just to describe each option as I suggested. Thank you!
Pull Request Test Coverage Report for Build 3564
💛 - Coveralls |
|
@balmas , waiting for your final approval :) |
For the issue - #323