Skip to content
This repository was archived by the owner on Feb 12, 2020. It is now read-only.

Conversation

balmas
Copy link
Member

@balmas balmas commented Aug 9, 2019

@kirlat and @irina060981 FYI, I am going to merge this ahead of code review because I need to get it up for weekend testing, but still would like your review on it. Thanks. See related PRs in alpheios_nemo_ui and embed-lib

Bridget Almas added 3 commits August 9, 2019 10:28
add support for overrideHelp option in uiController.create
help text changes
moving about alpheios from info to settings
remove placeholder text from lookup box
@balmas balmas requested review from irina060981 and kirlat August 9, 2019 15:24
@coveralls
Copy link

coveralls commented Aug 9, 2019

Pull Request Test Coverage Report for Build 3682

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 43.171%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/controllers/ui-controller.js 0 6 0.0%
Totals Coverage Status
Change from base Build 3675: -0.04%
Covered Lines: 1419
Relevant Lines: 3071

💛 - Coveralls

@kirlat
Copy link
Member

kirlat commented Aug 9, 2019

Looks good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants