Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add arethetypeswrong checking to use-* react libs #107

Merged
merged 2 commits into from
Sep 1, 2024
Merged

Conversation

altano
Copy link
Owner

@altano altano commented Sep 1, 2024

Note that these libs had incorrect types according to arethetypeswrong. This must have something to do with the react-library tsconfig not bundling the types together. Rather than investigate, I'm just switching to tsup's dts: true type generation which seems to work.

Stack created with Sapling. Best reviewed with ReviewStack.

altano added 2 commits August 31, 2024 17:18
Note that these libs had incorrect types according to arethetypeswrong. This must have something to do with the react-library tsconfig not bundling the types together. Rather than investigate, I'm just switching to tsup's `dts: true` type generation which seems to work.
Copy link

changeset-bot bot commented Sep 1, 2024

⚠️ No Changeset found

Latest commit: 8a8d979

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant