-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varying first cutoff time for each target group #258
Conversation
Codecov Report
@@ Coverage Diff @@
## main #258 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1270 1304 +34
=========================================
+ Hits 1270 1304 +34
|
Can you update the relevant docstring and maybe include an example in the documentation? |
@rwedge I updated the docstring and also added this guide in the docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we test a series that has a mix of date and number strings / a series that has only number strings?
@rwedge I updated the test to include timedelta string and integer values. Although using a mix of date and number can technically work, that seems like an edge use case and I don't think we should test that usage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #215 by supporting columns as values for
minimum_data
in a label search. This functionality allows users to vary the first cutoff time for each target group. For example, with a table of customers, you can start the labeling process at the varying times that the accounts were created.