Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests for end to end flow for data checks --> data check actions #2815

Closed
angela97lin opened this issue Sep 20, 2021 · 1 comment · Fixed by #2883
Closed
Assignees
Labels
spike To generate additional issues and kick off a sprint. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing.

Comments

@angela97lin
Copy link
Contributor

There are currently unit tests for both data checks and data check actions, but there's no test that takes the output of a data check and passes it to the code for data check actions. This has caused some issues with API consistency, found and written about in #2792. It could be good to create an end-to-end test flow that runs data checks, and feeds the output of validate to creating data check actions components.

This issue tracks adding integration tests (subfolder of tests) and creating a separate job for integration test suites?

@angela97lin angela97lin added testing Issues related to testing. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. spike To generate additional issues and kick off a sprint. labels Sep 20, 2021
@angela97lin angela97lin self-assigned this Sep 20, 2021
@angela97lin
Copy link
Contributor Author

Note: The immediate goal of this issue to define data check integration tests, but a secondary goal is to put in place a pattern for our more heavy lifting tests. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spike To generate additional issues and kick off a sprint. task Scripting, configuration, or other work which doesn't categorize well as a feature/enhancement/bug. testing Issues related to testing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant