Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements for nlp_primitives #1051

Merged
merged 5 commits into from
Aug 13, 2020
Merged

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Aug 13, 2020

  • Scipy requirement was restricted due to tensorflow, the upper bound can be removed
  • pip install featuretools[nlp_primitives] will install nlp_primitives with tensorflow, so install featuretools and nlp_primitives separately. Require the latest version of nlp_primitives to ensure tensorflow is not installed

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #1051 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files         187      187           
  Lines       10278    10278           
=======================================
  Hits        10269    10269           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81356e6...4530d9c. Read the comment docs.

@rwedge rwedge requested review from dsherry, freddyaboulton and eccabay and removed request for dsherry August 13, 2020 19:31
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rwedge !

@rwedge rwedge merged commit 0f08348 into main Aug 13, 2020
@dsherry dsherry mentioned this pull request Aug 25, 2020
@rwedge rwedge deleted the rw_update_nlp_primitives_reqs branch January 6, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants