Consolidate graphing methods #1060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
========================================
Coverage 99.91% 99.91%
========================================
Files 191 194 +3
Lines 10362 10986 +624
========================================
+ Hits 10353 10977 +624
Misses 9 9
Continue to review full report at Codecov.
|
freddyaboulton
approved these changes
Aug 14, 2020
|
I just left a related comment on the issue. Let's resolve that before merging this PR |
|
@dsherry I've addressed your comment! :D |
dsherry
approved these changes
Aug 17, 2020
|
|
||
|
|
||
| Model Understanding | ||
| =================== |
There was a problem hiding this comment.
Looks good!
Could be nice to move prediction explanations after the graphing stuff
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1053 by moving methods previously under
evalml/pipelines/graph_utils.pytoevalml/model_understanding/graphs.pyand consolidating tests fromevalml/tests/pipeline_tests/test_graphs.pyandevalml/tests/pipeline_tests/test_graph_utils.pytoevalml/tests/model_understanding_tests/test_graphs.py. Also moved prediction explanations fromevalml/pipelines/prediction_explanationstoevalml/model_understanding/prediction_explanations(@freddyaboulton FYI). I leftfeature_importancesalone since that's a property of a pipeline but open to comments / suggestions.Docs here: https://evalml.alteryx.com/en/1053_consolidate_graph/index.html
(Specifically, API ref change: https://evalml.alteryx.com/en/1053_consolidate_graph/api_reference.html#model-understanding)