-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate graphing methods #1060
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1060 +/- ##
========================================
Coverage 99.91% 99.91%
========================================
Files 191 194 +3
Lines 10362 10986 +624
========================================
+ Hits 10353 10977 +624
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin Looks good to me!
I just left a related comment on the issue. Let's resolve that before merging this PR |
@dsherry I've addressed your comment! :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 awesome, thank you!
|
||
|
||
Model Understanding | ||
=================== |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could be nice to move prediction explanations after the graphing stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
Closes #1053 by moving methods previously under
evalml/pipelines/graph_utils.py
toevalml/model_understanding/graphs.py
and consolidating tests fromevalml/tests/pipeline_tests/test_graphs.py
andevalml/tests/pipeline_tests/test_graph_utils.py
toevalml/tests/model_understanding_tests/test_graphs.py
. Also moved prediction explanations fromevalml/pipelines/prediction_explanations
toevalml/model_understanding/prediction_explanations
(@freddyaboulton FYI). I leftfeature_importances
alone since that's a property of a pipeline but open to comments / suggestions.Docs here: https://evalml.alteryx.com/en/1053_consolidate_graph/index.html
(Specifically, API ref change: https://evalml.alteryx.com/en/1053_consolidate_graph/api_reference.html#model-understanding)