-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize cost-benefit matrix values #1099
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1099 +/- ##
=======================================
Coverage 99.91% 99.91%
=======================================
Files 192 192
Lines 10719 10719
=======================================
Hits 10710 10710
Misses 9 9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🦺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, good call on this! I'd expect no change in ML performance from this, but its a good clarification. The benefit: if a user runs the same cost-benefit on two different training sets, where one has more rows than the other, the cost-benefit scores will have the same bounds.
I left one request for a math clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kmax12 Thanks for reminding me, updated docs here: https://evalml.alteryx.com/en/1098_normalize/demos/cost_benefit_matrix.html |
Closes #1098