Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enums for model_type instead of magic string. #110

Merged
merged 5 commits into from Oct 2, 2019

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Sep 27, 2019

Addresses #50 by using enums for model_type instead of magic strings.

@angela97lin angela97lin requested review from kmax12 and rwedge Sep 27, 2019
@codecov
Copy link

codecov bot commented Oct 1, 2019

Codecov Report

Merging #110 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   92.67%   92.74%   +0.06%     
==========================================
  Files          47       49       +2     
  Lines        1256     1268      +12     
==========================================
+ Hits         1164     1176      +12     
  Misses         92       92
Impacted Files Coverage Δ
evalml/tests/pipeline_tests/test_pipelines.py 93.61% <100%> (ø) ⬆️
evalml/models/auto_base.py 91.5% <100%> (ø) ⬆️
evalml/model_types/__init__.py 100% <100%> (ø)
evalml/pipelines/classification/random_forest.py 80% <100%> (+0.68%) ⬆️
evalml/pipelines/regression/random_forest.py 100% <100%> (ø) ⬆️
evalml/tests/automl_tests/test_autoclassifier.py 100% <100%> (ø) ⬆️
...ml/pipelines/classification/logistic_regression.py 93.54% <100%> (+0.21%) ⬆️
evalml/model_types/model_types.py 100% <100%> (ø)
evalml/pipelines/classification/xgboost.py 100% <100%> (ø) ⬆️
evalml/__init__.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 368f88e...b796377. Read the comment docs.

evalml/__init__.py Show resolved Hide resolved
rwedge
rwedge approved these changes Oct 1, 2019
Copy link
Contributor

@rwedge rwedge left a comment

Looks good!

@angela97lin angela97lin merged commit 698a80a into master Oct 2, 2019
@angela97lin angela97lin deleted the model_type_enums branch Oct 2, 2019
@angela97lin angela97lin mentioned this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants