TextFeaturizer test coverage update #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccabay
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 99.91% 99.93% +0.01%
==========================================
Files 194 194
Lines 10957 10959 +2
==========================================
+ Hits 10948 10952 +4
+ Misses 9 7 -2
Continue to review full report at Codecov.
|
angela97lin
approved these changes
Aug 27, 2020
| @@ -58,11 +58,6 @@ def _make_entity_set(self, X, text_columns): | |||
| es = self._ft.EntitySet() | |||
| es.entity_from_dataframe(entity_id='X', dataframe=X_text, index='index', make_index=True, | |||
| variable_types=all_text_variable_types) | |||
|
|
|||
There was a problem hiding this comment.
Is this dead code because we do the filtering for text variable types before we call _make_entity_set? :o
There was a problem hiding this comment.
It's dead because we now explicitly set all text columns to the Text type when generating the entityset (line 60), so they're guaranteed to all be the correct type during the deleted check!
There was a problem hiding this comment.
Got it, makes sense to me 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1120