Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextFeaturizer test coverage update #1122

Merged
merged 5 commits into from Aug 28, 2020
Merged

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Aug 27, 2020

Fixes #1120

@eccabay eccabay requested review from dsherry and angela97lin Aug 27, 2020
@eccabay eccabay self-assigned this Aug 27, 2020
@eccabay eccabay changed the title 1120 text featurizer test cov TextFeaturizer test coverage update Aug 27, 2020
@eccabay eccabay added the testing Issues related to testing. label Aug 27, 2020
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1122 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1122      +/-   ##
==========================================
+ Coverage   99.91%   99.93%   +0.01%     
==========================================
  Files         194      194              
  Lines       10957    10959       +2     
==========================================
+ Hits        10948    10952       +4     
+ Misses          9        7       -2     
Impacted Files Coverage Δ
...ents/transformers/preprocessing/text_featurizer.py 100.00% <ø> (+3.57%) ⬆️
...alml/tests/component_tests/test_text_featurizer.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e00e0f...c771400. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

LGTM! Just wanted to better understand why the deleted code was dead code but otherwise looks good :D

@@ -58,11 +58,6 @@ def _make_entity_set(self, X, text_columns):
es = self._ft.EntitySet()
es.entity_from_dataframe(entity_id='X', dataframe=X_text, index='index', make_index=True,
variable_types=all_text_variable_types)

Copy link
Contributor

@angela97lin angela97lin Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dead code because we do the filtering for text variable types before we call _make_entity_set? :o

Copy link
Contributor Author

@eccabay eccabay Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dead because we now explicitly set all text columns to the Text type when generating the entityset (line 60), so they're guaranteed to all be the correct type during the deleted check!

Copy link
Contributor

@angela97lin angela97lin Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, makes sense to me 🚢

@eccabay eccabay merged commit 7f85f95 into main Aug 28, 2020
This was referenced Sep 17, 2020
@eccabay eccabay deleted the 1120_text_featurizer_test_cov branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Issues related to testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text featurizer unit tests: fix codecov failure
2 participants