Remove CategoricalEncoder base class and get_feature_names function#1179
Merged
Remove CategoricalEncoder base class and get_feature_names function#1179
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1179 +/- ##
=======================================
Coverage 99.91% 99.92%
=======================================
Files 197 196 -1
Lines 11705 11700 -5
=======================================
- Hits 11695 11691 -4
+ Misses 10 9 -1
Continue to review full report at Codecov.
|
angela97lin
approved these changes
Sep 16, 2020
Contributor
angela97lin
left a comment
There was a problem hiding this comment.
Thanks for this cleanup! LGTM 👍
Contributor
Author
|
Note I filed a separate issue #1183 to track adding this attribute back in, with proper support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
get_feature_namesaccessor doesn't work, now that our one-hot encoder is more than a wrapper around the sklearn one-hot encoder, and we aren't using thecomponent_objcode path for it.Repro
Results in
Proposal
Let's delete
get_feature_names. We have a different API in place for accessing the list of the names of the features provided to each component in a pipeline.At that point,
CategoricalEncoderis just an empty class only referenced by one other piece of code. So we should remove it.