Remove CategoricalEncoder base class and get_feature_names function #1179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
get_feature_names
accessor doesn't work, now that our one-hot encoder is more than a wrapper around the sklearn one-hot encoder, and we aren't using thecomponent_obj
code path for it.Repro
Results in
Proposal
Let's delete
get_feature_names
. We have a different API in place for accessing the list of the names of the features provided to each component in a pipeline.At that point,
CategoricalEncoder
is just an empty class only referenced by one other piece of code. So we should remove it.