Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libomp dependency on Mac for LightGBM to docs #1233

Merged
merged 6 commits into from Sep 28, 2020
Merged

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Sep 28, 2020

fix #1216

Update install documentation for lightgbm on Mac. Local tests do fail on Mac when libomp isn't installed.

@bchen1116 bchen1116 self-assigned this Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #1233 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1233   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         196      196           
  Lines       12193    12193           
=======================================
  Hits        12184    12184           
  Misses          9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d2f3ce...cf63d49. Read the comment docs.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

@bchen1116 Looks good!

@bchen1116 bchen1116 merged commit 9998cf8 into main Sep 28, 2020
@angela97lin angela97lin mentioned this pull request Sep 29, 2020
@freddyaboulton freddyaboulton deleted the bc_1216_libomp branch May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightgbm: add note about libomp to our install docs
2 participants