Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing conda pre-release check from the release process documents. #1282

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

In PR #1247, we added a CI job to build our conda package whenever main gets updated. This simplifies our release process because we no longer need to do a pre-release to test whether conda can build our package. This PR removes these steps from our release process document.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #1282 into main will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1282      +/-   ##
==========================================
+ Coverage   99.76%   99.94%   +0.17%     
==========================================
  Files         213      213              
  Lines       13357    13357              
==========================================
+ Hits        13326    13349      +23     
+ Misses         31        8      -23     
Impacted Files Coverage Δ
...lml/tests/model_understanding_tests/test_graphs.py 100.00% <0.00%> (+0.13%) ⬆️
evalml/automl/automl_search.py 99.59% <0.00%> (+0.40%) ⬆️
.../automl_tests/test_automl_search_classification.py 100.00% <0.00%> (+0.43%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 100.00% <0.00%> (+0.67%) ⬆️
evalml/utils/gen_utils.py 100.00% <0.00%> (+0.83%) ⬆️
evalml/tests/component_tests/test_components.py 100.00% <0.00%> (+0.86%) ⬆️
...ests/automl_tests/test_automl_search_regression.py 100.00% <0.00%> (+1.06%) ⬆️
evalml/tests/component_tests/test_utils.py 100.00% <0.00%> (+1.85%) ⬆️
evalml/tests/utils_tests/test_dependencies.py 100.00% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1de8dd4...0b681f9. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the remove-conda-precheck-from-release branch from 313e075 to dec4d14 Compare October 8, 2020 20:45
@freddyaboulton freddyaboulton marked this pull request as ready for review October 8, 2020 20:58
@freddyaboulton freddyaboulton requested review from dsherry and angela97lin and removed request for dsherry October 8, 2020 20:59
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Really awesome that we no longer need to do this 🥳

@@ -183,16 +75,22 @@ pip freeze | grep evalml

Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv.

## 6. Publish Our New Conda Package
## 5. Publish Our New Conda Package
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freddyaboulton freddyaboulton force-pushed the remove-conda-precheck-from-release branch from dec4d14 to 0b681f9 Compare October 13, 2020 20:03
@freddyaboulton freddyaboulton merged commit 5690186 into main Oct 13, 2020
@freddyaboulton freddyaboulton deleted the remove-conda-precheck-from-release branch October 22, 2020 18:27
@dsherry dsherry mentioned this pull request Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants