-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing conda pre-release check from the release process documents. #1282
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
==========================================
+ Coverage 99.76% 99.94% +0.17%
==========================================
Files 213 213
Lines 13357 13357
==========================================
+ Hits 13326 13349 +23
+ Misses 31 8 -23
Continue to review full report at Codecov.
|
313e075
to
dec4d14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet! Really awesome that we no longer need to do this 🥳
@@ -183,16 +75,22 @@ pip freeze | grep evalml | |||
|
|||
Note: make sure when you do this that you're in a virtualenv, your current working directory isn't in the evalml repo, and that you haven't added your repo to the `PYTHONPATH`, because in both cases python could pick up the repo instead, even in a virtualenv. | |||
|
|||
## 6. Publish Our New Conda Package | |||
## 5. Publish Our New Conda Package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
dec4d14
to
0b681f9
Compare
Pull Request Description
In PR #1247, we added a CI job to build our conda package whenever
main
gets updated. This simplifies our release process because we no longer need to do a pre-release to test whether conda can build our package. This PR removes these steps from our release process document.After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.