-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Generation for Pipelines and Components #1306
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1306 +/- ##
==========================================
+ Coverage 99.95% 99.95% +0.01%
==========================================
Files 213 213
Lines 13656 13795 +139
==========================================
+ Hits 13649 13788 +139
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bchen1116 this is awesome!!! Fancy implementation for the pipeline method, wow, I like it. Means we won't have to update every time we add a new pipeline attribute.
I left a few comments but nothing major. I like the API!
I do have one consideration: for non-evalml component definitions, perhaps we should include the entire definition in the generated code. Like in your docs example, the generated code would include MyDropNullColumns
. What do you think? My reasoning is that if its not included in evalml, we should include it in the code gen.
Followed up with @bchen1116 , we're gonna pass on including custom component source in the generated code, because the implementation for handling imports would be complex. We'll wait to get a user request / feedback before adding the ability to include custom components in the generated code output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 ✨
fix #1028
Design Doc here
Component docs here
Pipeline docs here
Api docs here and here
Requirements: