Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to contributing.md after working with Raymond to set up dev env #1310

Merged
merged 3 commits into from
Oct 15, 2020
Merged

Updates to contributing.md after working with Raymond to set up dev env #1310

merged 3 commits into from
Oct 15, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Oct 15, 2020 •
edited
Loading

Thanks @rpeck !

Docs will be viewable here once the build completes.
Contributing guide visible here.

@dsherry dsherry added the documentation Improvements or additions to documentation label Oct 15, 2020
@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #1310 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files         213      213           
  Lines       13357    13357           
=======================================
  Hits        13349    13349           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9535160...0dfda8a. Read the comment docs.

freddyaboulton
freddyaboulton approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

angela97lin
angela97lin approved these changes Oct 15, 2020
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM!

Left the tiniest nit-pick comment 😂

contributing.md Outdated Show resolved Hide resolved
@dsherry dsherry merged commit f301845 into main Oct 15, 2020
@dsherry dsherry deleted the ds_update_contributing branch October 15, 2020 19:15
@dsherry dsherry mentioned this pull request Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela97lin angela97lin angela97lin approved these changes

@freddyaboulton freddyaboulton freddyaboulton approved these changes

@rpeck rpeck Awaiting requested review from rpeck

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherry @angela97lin @freddyaboulton