Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added _pipelines_per_batch as a private argument to AutoMLSearch #1355

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Added _pipelines_per_batch as a private argument to AutoMLSearch #1355

merged 2 commits into from
Oct 27, 2020

Conversation

christopherbunn
Copy link
Contributor

Resolves #1339

@christopherbunn christopherbunn changed the title Added _pipelines_per_batch as private param for AutoML Added _pipelines_per_batch as private parameter for AutoML Oct 27, 2020
@christopherbunn christopherbunn changed the title Added _pipelines_per_batch as private parameter for AutoML Added _pipelines_per_batch as a private argument to AutoMLSearch Oct 27, 2020
@codecov
Copy link

codecov bot commented Oct 27, 2020 •
edited
Loading

Codecov Report

Merging #1355 into main will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1355      +/-   ##
==========================================
+ Coverage   99.95%   99.95%   +0.01%     
==========================================
  Files         213      213              
  Lines       13609    13632      +23     
==========================================
+ Hits        13602    13625      +23     
  Misses          7        7
Impacted Files Coverage Δ
evalml/automl/automl_search.py 99.62% <100.00%> (ø)
evalml/tests/automl_tests/test_automl.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba5863e...dde1e5d. Read the comment docs.

@christopherbunn christopherbunn marked this pull request as ready for review October 27, 2020 18:27
@christopherbunn christopherbunn self-assigned this Oct 27, 2020
dsherry
dsherry approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopherbunn looks great!! Thanks :D

dsherry
dsherry reviewed Oct 27, 2020
View reviewed changes
evalml/tests/automl_tests/test_automl.py
def total_pipelines(automl, num_batches, batch_size):
total = 1 + len(automl.allowed_pipelines)
total += ((num_batches - 1) * batch_size)
return total
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neat, nice to see this math condensed

@christopherbunn christopherbunn merged commit 397d734 into main Oct 27, 2020
@dsherry dsherry mentioned this pull request Oct 29, 2020
Merged
@freddyaboulton freddyaboulton deleted the 1339_add_pipelines_per_batch branch May 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherry dsherry dsherry approved these changes

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@angela97lin angela97lin Awaiting requested review from angela97lin

@bchen1116 bchen1116 Awaiting requested review from bchen1116

@eccabay eccabay Awaiting requested review from eccabay

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

Assignees

@christopherbunn christopherbunn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add _pipelines_per_batch as a private parameter for AutoML Search
2 participants
@christopherbunn @dsherry