Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing guide for CLA #1402

Merged
merged 2 commits into from
Nov 3, 2020
Merged

Update contributing guide for CLA #1402

merged 2 commits into from
Nov 3, 2020

Conversation

dsherry
Copy link
Contributor

@dsherry dsherry commented Nov 3, 2020 •
edited
Loading

Also using this to test that the CLA works properly

@dsherry dsherry self-assigned this Nov 3, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@dsherry dsherry marked this pull request as ready for review November 3, 2020 19:49
@codecov
Copy link

codecov bot commented Nov 3, 2020 •
edited
Loading

Codecov Report

Merging #1402 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1402   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         213      213           
  Lines       13929    13929           
=======================================
  Hits        13922    13922           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102f741...2e41267. Read the comment docs.

@dsherry dsherry marked this pull request as draft November 3, 2020 20:13
@dsherry dsherry marked this pull request as ready for review November 3, 2020 20:13
@dsherry dsherry added the documentation Improvements or additions to documentation label Nov 3, 2020
angela97lin
angela97lin approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM 🥳 🎈

@dsherry dsherry merged commit b16000e into main Nov 3, 2020
@dsherry dsherry mentioned this pull request Nov 24, 2020
Merged
@freddyaboulton freddyaboulton deleted the ds_update_contrib_cla branch May 13, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angela97lin angela97lin angela97lin approved these changes

@freddyaboulton freddyaboulton Awaiting requested review from freddyaboulton

@bchen1116 bchen1116 Awaiting requested review from bchen1116

@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih

@kmax12 kmax12 Awaiting requested review from kmax12

@christopherbunn christopherbunn Awaiting requested review from christopherbunn

@eccabay eccabay Awaiting requested review from eccabay

Assignees

@dsherry dsherry

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsherry @CLAassistant @angela97lin