Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stacked ensembling to AutoML documentation #1425

Merged
merged 10 commits into from
Nov 24, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 11, 2020

Closes #1329

Docs here

@angela97lin angela97lin self-assigned this Nov 11, 2020
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #1425 (816d5e4) into main (e2b1030) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1425   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         223      223           
  Lines       14930    14930           
=======================================
  Hits        14923    14923           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b1030...816d5e4. Read the comment docs.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just some comments!

docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin This looks good to me! This is out of scope of this PR but this sentence might be confusing to users because I don't think we ever explain how the batching in AutoML works:

The stacking ensemble pipeline runs in its own batch after a whole cycle of training has occurred (each allowed pipeline trains for one batch). Note that this means a large number of iterations may need to run before the stacking ensemble runs.

One thing we can do is add something to the AutoML printout like this if the number of iterations selected by the user is too small:

Ensembling set to true but the number of iterations is too small
for ensembling to run. Set it to at least ...

and

Ensembling is set to True and max_iterations is set to ... 
so ensembling will run in batches 4, 8, 12 

That way users are not so confused about whether or not ensembling will run. Like I said, out of scope of this PR, but I think this would be a useful enhancement in the future!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just left one comment but not blocking

docs/source/user_guide/automl.ipynb Show resolved Hide resolved
@angela97lin angela97lin added this to the November 2020 milestone Nov 18, 2020
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@angela97lin looks good to me!

I only had one change request, which was to use max_batches=5 (or 4? forgetting) instead of max_iterations=20

docs/source/user_guide/automl.ipynb Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
docs/source/user_guide/automl.ipynb Outdated Show resolved Hide resolved
@angela97lin
Copy link
Contributor Author

@freddyaboulton Great suggestion!! I filed #1461 to track this 😁

@angela97lin angela97lin merged commit a5e17f8 into main Nov 24, 2020
@angela97lin angela97lin deleted the 1329_stacked_ensemble_docs branch November 24, 2020 06:03
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation about stacked ensembles in AutoML
5 participants