New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update data checks to return a dictionary #1448
Conversation
…alml into 1325_data_checks_returns_dict
Codecov Report
@@ Coverage Diff @@
## main #1448 +/- ##
=========================================
+ Coverage 100.0% 100.0% +0.1%
=========================================
Files 220 220
Lines 14672 14699 +27
=========================================
+ Hits 14665 14692 +27
Misses 7 7
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one suggestion but not blocking
Continuation of #1444, closes #1325
Rather than returning the
DataCheckMessage
classes themselves, we now return the dictionary version so that validate returns: