Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data checks to return a dictionary #1448

Merged
merged 29 commits into from
Nov 20, 2020

Conversation

angela97lin
Copy link
Contributor

@angela97lin angela97lin commented Nov 19, 2020

Continuation of #1444, closes #1325

Rather than returning the DataCheckMessage classes themselves, we now return the dictionary version so that validate returns:

{ "errors": [{"message": "message here", "data_check_name": "name here", "level": "error"}],
 "warnings": [#same here]
}

@angela97lin angela97lin added this to the November 2020 milestone Nov 19, 2020
@angela97lin angela97lin self-assigned this Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #1448 (a4a8d72) into main (f54abd3) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #1448     +/-   ##
=========================================
+ Coverage   100.0%   100.0%   +0.1%     
=========================================
  Files         220      220             
  Lines       14672    14699     +27     
=========================================
+ Hits        14665    14692     +27     
  Misses          7        7             
Impacted Files Coverage Δ
evalml/data_checks/default_data_checks.py 100.0% <ø> (ø)
evalml/automl/automl_search.py 99.7% <100.0%> (-<0.1%) ⬇️
evalml/data_checks/class_imbalance_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/data_check_message.py 100.0% <100.0%> (ø)
evalml/data_checks/data_checks.py 100.0% <100.0%> (ø)
evalml/data_checks/high_variance_cv_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/highly_null_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/id_columns_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/invalid_targets_data_check.py 100.0% <100.0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54abd3...a4a8d72. Read the comment docs.

@angela97lin angela97lin marked this pull request as ready for review November 19, 2020 19:56
Copy link
Contributor

@dsherry dsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one suggestion but not blocking

evalml/data_checks/no_variance_data_check.py Outdated Show resolved Hide resolved
docs/source/release_notes.rst Outdated Show resolved Hide resolved
@angela97lin angela97lin merged commit 9dfcc4b into main Nov 20, 2020
@angela97lin angela97lin deleted the 1325_data_checks_returns_dict_revamped branch November 20, 2020 04:50
@dsherry dsherry mentioned this pull request Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data checks: make it easier to process results
2 participants