Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of DataTable/DataColumn from docs #2445

Merged
merged 2 commits into from
Jun 25, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Jun 24, 2021

Pull Request Description

Fixes #2051
Fixes #1965

I think I got them all!

image


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #2445 (0acdfb5) into main (754a018) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2445   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        283     283           
  Lines      25478   25478           
=====================================
  Hits       25378   25378           
  Misses       100     100           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754a018...0acdfb5. Read the comment docs.

@freddyaboulton freddyaboulton self-assigned this Jun 24, 2021
@freddyaboulton freddyaboulton marked this pull request as ready for review June 24, 2021 20:54
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - nice to clear this up!

Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@freddyaboulton freddyaboulton merged commit 209d5e1 into main Jun 25, 2021
@freddyaboulton freddyaboulton deleted the 2051-ww-accessor-demos branch June 25, 2021 14:41
@dsherry dsherry mentioned this pull request Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure demos have been updated with new accessor Update woodwork: support accessor API
4 participants