Remove LinearRegressor from default AutoMLSearch estimators #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2660 +/- ##
=====================================
Coverage 99.9% 99.9%
=====================================
Files 298 298
Lines 27305 27305
=====================================
Hits 27261 27261
Misses 44 44
Continue to review full report at Codecov.
|
freddyaboulton
requested review from
chukarsten,
dsherry,
angela97lin,
bchen1116,
christopherbunn,
eccabay,
jeremyliweishih and
ParthivNaresh
and removed request for
chukarsten and
dsherry
dsherry
reviewed
Aug 19, 2021
| @@ -129,7 +129,7 @@ def __init__( | |||
| def _naive_estimators(self): | |||
| if is_regression(self.problem_type): | |||
| naive_estimators = [ | |||
| "Linear Regressor", | |||
| "Elastic Net Regressor", | |||
There was a problem hiding this comment.
Hm so were we not running elastic net in automl before this point? That doesn't match with my memory but perhaps I've just forgotten the details of the plumbing here, lol
There was a problem hiding this comment.
This is on the new algorithm @jeremyliweishih wrote so not what's run by default in AutoMLSearch right now. In AutoMLSearch we run elastic net by default!
freddyaboulton
force-pushed
the
2589-fix-regress-csv
branch
from
bbfad23
to
87ce8df
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2589
Rationale here
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.