Skip to content

Conversation

@freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2708


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@freddyaboulton freddyaboulton self-assigned this Aug 30, 2021
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #2710 (10870df) into main (a83e60e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2710   +/-   ##
=====================================
  Coverage   99.9%   99.9%           
=====================================
  Files        300     300           
  Lines      27426   27426           
=====================================
  Hits       27382   27382           
  Misses        44      44           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a83e60e...10870df. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review August 30, 2021 16:11
with:
repository: ${{ github.repository }}
ref: main
ref: fix-broken-nightlies
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert prior to merge

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @freddyaboulton!👍

on:
schedule:
- cron: '0 3 * * *'
pull_request:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just to test right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure!

@freddyaboulton freddyaboulton merged commit 1def4fe into main Aug 30, 2021
@chukarsten chukarsten mentioned this pull request Sep 1, 2021
@freddyaboulton freddyaboulton deleted the fix-broken-nightlies branch May 13, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing Windows Unit Tests - Unable to install certain dependencies

3 participants