Pass X_train and y_train to graph_prediction_vs_actual_over_time #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2762 +/- ##
=======================================
- Coverage 99.8% 99.8% -0.0%
=======================================
Files 301 301
Lines 27897 27889 -8
=======================================
- Hits 27834 27826 -8
Misses 63 63
Continue to review full report at Codecov.
|
freddyaboulton
force-pushed
the
2731-graph-prediction-over-time-fix
branch
from
6686981
to
672e243
Compare
freddyaboulton
requested review from
angela97lin,
chukarsten,
bchen1116,
christopherbunn,
dsherry,
eccabay,
jeremyliweishih and
ParthivNaresh
and removed request for
chukarsten
freddyaboulton
commented
Sep 10, 2021
| @@ -7,6 +7,9 @@ Release Notes | |||
| * Set ``eval_metric`` to ``logloss`` for ``XGBoostClassifier`` :pr:`2741` | |||
| * Added support for ``woodwork`` versions ``0.7.0`` and ``0.7.1`` :pr:`2743` | |||
| * Changed ``explain_predictions`` functions to display original feature values :pr:`2759` | |||
| * Added ``X_train`` and ``y_train`` to ``graph_prediction_vs_actual_over_time`` and ``get_prediction_vs_actual_over_time_data`` :pr:`2762` | |||
| * Added ``forecast_horizon`` as a required parameter to time series pipelines and ``AutoMLSearch`` :pr:`2697` | |||
There was a problem hiding this comment.
Accidentally put the release notes for 2697 into the previous release during a rebase lol
chukarsten
approved these changes
Sep 10, 2021
angela97lin
approved these changes
Sep 10, 2021
| " xaxis={\"title\": \"Time\"},\n", | ||
| " yaxis={\"title\": \"Target Values and Predictions\"},\n", | ||
| ")\n", | ||
| "from evalml.model_understanding import graph_prediction_vs_actual_over_time\n", |
There was a problem hiding this comment.
Love how simple this is!
| @@ -1427,22 +1427,23 @@ def visualize_decision_tree( | |||
| return source_obj | |||
|
|
|||
|
|
|||
| def get_prediction_vs_actual_over_time_data(pipeline, X, y, dates): | |||
| def get_prediction_vs_actual_over_time_data(pipeline, X, y, X_train, y_train, dates): | |||
There was a problem hiding this comment.
Was this a bug? Or simply doing something different? If the latter, is there any functionality that we want to keep around?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #2731
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.