-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass X_train, y_train in Engine.submit_scoring_job for time series #2786
Pass X_train, y_train in Engine.submit_scoring_job for time series #2786
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2786 +/- ##
=======================================
+ Coverage 99.0% 99.8% +0.8%
=======================================
Files 298 298
Lines 27646 27681 +35
=======================================
+ Hits 27364 27613 +249
+ Misses 282 68 -214
Continue to review full report at Codecov.
|
|
||
@pytest.mark.parametrize( | ||
"engine_str", | ||
engine_strs + ["sequential"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chukarsten Check it out - threaded engines respect mocks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid catch, looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 😁
@@ -159,6 +163,7 @@ def submit_scoring_job(self, automl_config, pipeline, X, y, objectives): | |||
X_schema = X.ww.schema | |||
y_schema = y.ww.schema | |||
X, y = self.send_data_to_cluster(X, y) | |||
X_train, y_train = self.send_data_to_cluster(X_train, y_train) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own curiosity: theoretically, if send_data_to_cluster
supported more arguments, this could have been combined with the line above, right? 🤔
X_train, y_train = X[:50], y[:50] | ||
X_test, y_test = X[50:], y[50:] | ||
X_train, y_train = pd.DataFrame(X_train), pd.Series(y_train) | ||
X_test, y_test = pd.DataFrame(X_test), pd.Series(y_test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Omega nitpick: could probably combine these lines to:
X_train, y_train = pd.DataFrame(X[:50]), pd.Series(y[:50])
X_test, y_test = pd.DataFrame(X[50:]), pd.Series(y[50:])
But might just be personal preference 😅
Side note: This is probably a task for the larger test refactoring/cleanup PR, but I wonder if it's worth making our fixtures dataframes, since we've slowly been moving away from explicitly supporting numpy arrays lol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@angela97lin Agreed that having our most common fixtures be numpy arrays is not ideal - maybe tests our code with unrepresentative inputs compared to what a user would pass in!
2ecef68
to
a654370
Compare
a654370
to
23aeeb5
Compare
Pull Request Description
Fixes #2785
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.