Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete EmptyDataChecks #2794

Merged
merged 3 commits into from
Sep 17, 2021
Merged

Delete EmptyDataChecks #2794

merged 3 commits into from
Sep 17, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Sep 16, 2021

Pull Request Description

Fixes #2702


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #2794 (74d5b6e) into main (0440bec) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2794     +/-   ##
=======================================
- Coverage   99.8%   99.8%   -0.0%     
=======================================
  Files        298     297      -1     
  Lines      27731   27715     -16     
=======================================
- Hits       27663   27647     -16     
  Misses        68      68             
Impacted Files Coverage Δ
evalml/data_checks/__init__.py 100.0% <ø> (ø)
evalml/tests/data_checks_tests/test_data_checks.py 100.0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0440bec...74d5b6e. Read the comment docs.

@freddyaboulton freddyaboulton marked this pull request as ready for review September 16, 2021 22:23
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 😁

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#canceled

@freddyaboulton freddyaboulton merged commit c0ed2ba into main Sep 17, 2021
@freddyaboulton freddyaboulton deleted the 2703-remove-empty-data-checks branch September 17, 2021 14:26
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove EmptyDataChecks class
4 participants