Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show DeprecationWarning when Sklearn Ensemblers are called #2859

Merged
merged 6 commits into from
Sep 30, 2021

Conversation

christopherbunn
Copy link
Contributor

When a sklearn ensembler is instantiated, show a warning that it will removed in the next release.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #2859 (013d7ea) into main (7353fa6) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #2859     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        305     305             
  Lines      28353   28373     +20     
=======================================
+ Hits       28272   28292     +20     
  Misses        81      81             
Impacted Files Coverage Δ
...mponents/ensemble/sklearn_stacked_ensemble_base.py 100.0% <100.0%> (ø)
..._tests/test_sklearn_stacked_ensemble_classifier.py 100.0% <100.0%> (ø)
...t_tests/test_sklearn_stacked_ensemble_regressor.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7353fa6...013d7ea. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Just left a comment about the test name 😅

@@ -194,3 +195,18 @@ def test_sklearn_stacked_feature_importance(
NotImplementedError, match="feature_importance is not implemented"
):
clf.feature_importance


def test_component_graph_from_list_deprecation_warning(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test name might be wrong? 😂

@christopherbunn christopherbunn merged commit 32044c1 into main Sep 30, 2021
@chukarsten chukarsten mentioned this pull request Oct 1, 2021
@freddyaboulton freddyaboulton deleted the sklearn_ensembler_dep_warning branch May 13, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants