-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show DeprecationWarning when Sklearn Ensemblers are called #2859
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2859 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 305 305
Lines 28353 28373 +20
=======================================
+ Hits 28272 28292 +20
Misses 81 81
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Just left a comment about the test name 😅
@@ -194,3 +195,18 @@ def test_sklearn_stacked_feature_importance( | |||
NotImplementedError, match="feature_importance is not implemented" | |||
): | |||
clf.feature_importance | |||
|
|||
|
|||
def test_component_graph_from_list_deprecation_warning( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test name might be wrong? 😂
When a sklearn ensembler is instantiated, show a warning that it will removed in the next release.