Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do build_conda_pkg from local recipe #2925

Merged
merged 10 commits into from Oct 18, 2021

Conversation

freddyaboulton
Copy link
Contributor

@freddyaboulton freddyaboulton commented Oct 14, 2021

Pull Request Description

Make it easier/less confusing to fix a failing build_conda_pkg job by letting users edit a local copy of the recipe instead.

The idea is to hold the latest valid recipe in the EvalML repo as opposed to tracking that in latest_release_changes. This lets devs make changes to the recipe in isolation to get build_conda_pkg to pass. I also figure it'll be more intuitive if all the files needed to make a PR green are located in the EvalML repo.

We already have CI in place in the feedstock to check that the feedstock recipe matches the EvalML recipe so the two recipes should always be in synch.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #2925 (4fe2569) into main (d83e074) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2925   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        302     302           
  Lines      28412   28412           
=====================================
  Hits       28319   28319           
  Misses        93      93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d83e074...4fe2569. Read the comment docs.

@@ -11,7 +11,7 @@ click>=7.1.2
psutil>=5.6.6
requirements-parser>=0.2.0
shap>=0.36.0
texttable>=1.6.2
texttable==1.6.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete prior to merge

@@ -13,6 +13,12 @@ def _get_req_name(name):
return name


def test_texttable_version():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will delete prior to merge. But the fact this passes means build_conda_pkg is building from the local recipe!

- psutil >=5.6.6
- requirements-parser >=0.2.0
- shap >=0.36.0
- texttable ==1.6.3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will revert prior to merge

@freddyaboulton freddyaboulton force-pushed the make-it-easier-to-fix-build-conda-pkg branch from 69bb221 to 2e7e95b Compare October 15, 2021 15:17
@freddyaboulton freddyaboulton marked this pull request as ready for review October 15, 2021 17:40
@freddyaboulton freddyaboulton changed the title WIP: Do build_conda_pkg from local recipe Do build_conda_pkg from local recipe Oct 15, 2021
Copy link
Collaborator

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding. This PR is great by itself, but also great in that it got me to reread the build_conda_pkg section again. Thank you for continually taking steps to streamline this!!

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this, I think this will definitely make it much more obvious for devs :} Thanks, @freddyaboulton! 👏

@freddyaboulton freddyaboulton force-pushed the make-it-easier-to-fix-build-conda-pkg branch from 2e7e95b to 4fe2569 Compare October 18, 2021 17:31
@freddyaboulton freddyaboulton merged commit e667959 into main Oct 18, 2021
@freddyaboulton freddyaboulton deleted the make-it-easier-to-fix-build-conda-pkg branch October 18, 2021 18:05
@chukarsten chukarsten mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants