Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps-checker regex to gather full names #2930

Merged
merged 3 commits into from Oct 15, 2021
Merged

Fix deps-checker regex to gather full names #2930

merged 3 commits into from Oct 15, 2021

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Oct 15, 2021

There was a bug where the deps checker would grab just the first part of hyphenated package names, currently causing me issues over in PR #2905.

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #2930 (711b5a8) into main (a65e98b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2930   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        302     302           
  Lines      28396   28396           
=====================================
  Hits       28303   28303           
  Misses        93      93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65e98b...711b5a8. Read the comment docs.

@gsheni gsheni requested a review from rwedge October 15, 2021 18:05
Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@eccabay eccabay merged commit d4271a8 into main Oct 15, 2021
@freddyaboulton freddyaboulton deleted the deps_checker branch October 15, 2021 20:27
@chukarsten chukarsten mentioned this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants