Fix deps-checker regex to gather full names #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eccabay
requested review from
bchen1116,
freddyaboulton,
chukarsten and
jeremyliweishih
Codecov Report
@@ Coverage Diff @@
## main #2930 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 302 302
Lines 28396 28396
=====================================
Hits 28303 28303
Misses 93 93 Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where the deps checker would grab just the first part of hyphenated package names, currently causing me issues over in PR #2905.