-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for Binary Classification Threshold Tuning #2937
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2937 +/- ##
=====================================
Coverage 99.7% 99.7%
=====================================
Files 302 302
Lines 28593 28593
=====================================
Hits 28500 28500
Misses 93 93 Continue to review full report at Codecov.
|
@@ -480,49 +618,6 @@ | |||
"exec(code)\n", | |||
"pipeline.fit(X, y)" | |||
] | |||
}, | |||
{ | |||
"cell_type": "markdown", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved this cell to follow the cells that describe the binary classif. threshold for continuity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing we need to add, in my opinion, is a mention of how the rows near the decision boundary are returned. So maybe a mention of a default epsilon to highlight that methodology. Otherwise, I think this is well organized and instructive! Nice job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @bchen1116 ! I left a minor nit but otherwise I agree with @chukarsten 's comment so thank you for making the change.
fix #2825
Docs are here