Skip to content

Add documentation for Binary Classification Threshold Tuning - #2937

Merged
bchen1116 merged 7 commits into
mainfrom
bc_2825_threshold
Oct 20, 2021
Merged

Add documentation for Binary Classification Threshold Tuning#2937
bchen1116 merged 7 commits into
mainfrom
bc_2825_threshold

Conversation

@bchen1116

@bchen1116 bchen1116 commented Oct 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

fix #2825

Docs are here

@bchen1116 bchen1116 self-assigned this Oct 19, 2021
@codecov

codecov Bot commented Oct 19, 2021 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2937 (4cf2b15) into main (08601ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2937   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        302     302           
  Lines      28593   28593           
=====================================
  Hits       28500   28500           
  Misses        93      93

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08601ea...4cf2b15. Read the comment docs.

bchen1116
bchen1116 commented Oct 19, 2021
View reviewed changes
Comment thread docs/source/user_guide/pipelines.ipynb
]
},
{
"cell_type": "markdown",

@bchen1116 bchen1116 Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this cell to follow the cells that describe the binary classif. threshold for continuity

chukarsten
chukarsten previously requested changes Oct 19, 2021
View reviewed changes

@chukarsten chukarsten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing we need to add, in my opinion, is a mention of how the rows near the decision boundary are returned. So maybe a mention of a default epsilon to highlight that methodology. Otherwise, I think this is well organized and instructive! Nice job.

@bchen1116
bchen1116 requested a review from chukarsten October 20, 2021 15:19
freddyaboulton
freddyaboulton approved these changes Oct 20, 2021
View reviewed changes

@freddyaboulton freddyaboulton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bchen1116 ! I left a minor nit but otherwise I agree with @chukarsten 's comment so thank you for making the change.

Comment thread docs/source/user_guide/pipelines.ipynb Outdated
@bchen1116
bchen1116 merged commit 752fba5 into main Oct 20, 2021
@chukarsten chukarsten mentioned this pull request Oct 27, 2021
Merged
@freddyaboulton
freddyaboulton deleted the bc_2825_threshold branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dsherry dsherry Awaiting requested review from dsherry
@angela97lin angela97lin Awaiting requested review from angela97lin
@jeremyliweishih jeremyliweishih Awaiting requested review from jeremyliweishih
@ParthivNaresh ParthivNaresh Awaiting requested review from ParthivNaresh
@christopherbunn christopherbunn Awaiting requested review from christopherbunn
@chukarsten chukarsten Awaiting requested review from chukarsten
1 more reviewer
@freddyaboulton freddyaboulton freddyaboulton approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@bchen1116 bchen1116

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

User guide: binary classification threshold tuning

3 participants

@bchen1116 @freddyaboulton @chukarsten