Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for Binary Classification Threshold Tuning #2937

Merged
merged 7 commits into from
Oct 20, 2021

Conversation

bchen1116
Copy link
Contributor

@bchen1116 bchen1116 commented Oct 19, 2021

fix #2825

Docs are here

@bchen1116 bchen1116 self-assigned this Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #2937 (4cf2b15) into main (08601ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2937   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        302     302           
  Lines      28593   28593           
=====================================
  Hits       28500   28500           
  Misses        93      93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08601ea...4cf2b15. Read the comment docs.

@@ -480,49 +618,6 @@
"exec(code)\n",
"pipeline.fit(X, y)"
]
},
{
"cell_type": "markdown",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this cell to follow the cells that describe the binary classif. threshold for continuity

Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the only thing we need to add, in my opinion, is a mention of how the rows near the decision boundary are returned. So maybe a mention of a default epsilon to highlight that methodology. Otherwise, I think this is well organized and instructive! Nice job.

Copy link
Contributor

@freddyaboulton freddyaboulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bchen1116 ! I left a minor nit but otherwise I agree with @chukarsten 's comment so thank you for making the change.

docs/source/user_guide/pipelines.ipynb Outdated Show resolved Hide resolved
@bchen1116 bchen1116 merged commit 752fba5 into main Oct 20, 2021
@chukarsten chukarsten mentioned this pull request Oct 27, 2021
@freddyaboulton freddyaboulton deleted the bc_2825_threshold branch May 13, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User guide: binary classification threshold tuning
3 participants