-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include boolean as a categorical type when selecting Oversampler #2980
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2980 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 307 307
Lines 29244 29257 +13
=======================================
+ Hits 29153 29166 +13
Misses 91 91
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, good catch! Thank you 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, quick fix. Thanks!!
Closes #2947
Fixes error where having exclusively categorical and boolean columns would have our oversampler selection code pick SMOTENC to use, when it should have been SMOTEN, throwing an error
SMOTE-NC is not designed to work only with categorical features