Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data check Update #3018

Merged
merged 16 commits into from
Nov 9, 2021
Merged

Data check Update #3018

merged 16 commits into from
Nov 9, 2021

Conversation

ParthivNaresh
Copy link
Contributor

A data check update and suspension of the nullable types check until the Nullable work is merged.


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #3018 (666030c) into main (ec4e563) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3018   +/-   ##
=====================================
  Coverage   99.8%   99.8%           
=====================================
  Files        312     312           
  Lines      30162   30162           
=====================================
  Hits       30073   30073           
  Misses        89      89           
Impacted Files Coverage Δ
evalml/data_checks/highly_null_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/no_variance_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/outliers_data_check.py 100.0% <100.0%> (ø)
evalml/data_checks/uniqueness_data_check.py 100.0% <100.0%> (ø)
evalml/utils/woodwork_utils.py 100.0% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4e563...666030c. Read the comment docs.

@ParthivNaresh ParthivNaresh self-assigned this Nov 8, 2021
Copy link
Contributor

@chukarsten chukarsten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool man! I'll add this to the nullable types doc and we can get you unblocked.

@ParthivNaresh ParthivNaresh merged commit 3348464 into main Nov 9, 2021
@ParthivNaresh ParthivNaresh deleted the DataCheck_Update branch November 9, 2021 15:35
@chukarsten chukarsten mentioned this pull request Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants