Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete predict_uses_y #3069

Merged
merged 4 commits into from
Nov 17, 2021
Merged

Delete predict_uses_y #3069

merged 4 commits into from
Nov 17, 2021

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #2961


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Nov 16, 2021

Codecov Report

Merging #3069 (1aea944) into main (3e00450) will increase coverage by 0.1%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3069     +/-   ##
=======================================
+ Coverage   99.8%   99.8%   +0.1%     
=======================================
  Files        312     312             
  Lines      30240   30232      -8     
=======================================
- Hits       30150   30144      -6     
+ Misses        90      88      -2     
Impacted Files Coverage Δ
...valml/pipelines/components/estimators/estimator.py 100.0% <ø> (ø)
...ators/regressors/time_series_baseline_estimator.py 100.0% <ø> (ø)
.../pipelines/time_series_classification_pipelines.py 100.0% <100.0%> (+1.1%) ⬆️
evalml/pipelines/time_series_pipeline_base.py 100.0% <100.0%> (+1.0%) ⬆️
.../tests/pipeline_tests/test_time_series_pipeline.py 99.8% <100.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e00450...1aea944. Read the comment docs.

Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, glad that we're able to simplify things even more :)

I still see a reference to it in docs/source/_templates/estimator_class.rst that we'll probably want to remove too?

   {% block attributes %}
   .. Class attributes:
   .. autoattribute:: name
   .. autoattribute:: model_family
   .. autoattribute:: supported_problem_types
   .. autoattribute:: hyperparameter_ranges
   .. autoattribute:: default_parameters
   .. autoattribute:: predict_uses_y
   {% endblock %}

@freddyaboulton
Copy link
Contributor Author

@angela97lin Done!

@freddyaboulton freddyaboulton merged commit a20dcd1 into main Nov 17, 2021
@freddyaboulton freddyaboulton deleted the 2961-remove-predict-uses-y branch November 17, 2021 15:40
@chukarsten chukarsten mentioned this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the predict_uses_y estimator property
2 participants