-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete predict_uses_y #3069
Delete predict_uses_y #3069
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3069 +/- ##
=======================================
+ Coverage 99.8% 99.8% +0.1%
=======================================
Files 312 312
Lines 30240 30232 -8
=======================================
- Hits 30150 30144 -6
+ Misses 90 88 -2
Continue to review full report at Codecov.
|
21353c1
to
49eef49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, glad that we're able to simplify things even more :)
I still see a reference to it in docs/source/_templates/estimator_class.rst
that we'll probably want to remove too?
{% block attributes %}
.. Class attributes:
.. autoattribute:: name
.. autoattribute:: model_family
.. autoattribute:: supported_problem_types
.. autoattribute:: hyperparameter_ranges
.. autoattribute:: default_parameters
.. autoattribute:: predict_uses_y
{% endblock %}
@angela97lin Done! |
Pull Request Description
Fixes #2961
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.