Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename date_index to time_index #3137

Merged
merged 4 commits into from Dec 10, 2021
Merged

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3074


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #3137 (6816f2a) into main (e31c88f) will not change coverage.
The diff coverage is 100.0%.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3137   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        318     318           
  Lines      30756   30756           
=====================================
  Hits       30652   30652           
  Misses       104     104           
Impacted Files Coverage Δ
evalml/automl/utils.py 100.0% <ø> (ø)
...omponents/estimators/regressors/arima_regressor.py 100.0% <ø> (ø)
.../transformers/preprocessing/datetime_featurizer.py 100.0% <ø> (ø)
.../pipelines/time_series_classification_pipelines.py 100.0% <ø> (ø)
...valml/pipelines/time_series_regression_pipeline.py 100.0% <ø> (ø)
evalml/preprocessing/utils.py 100.0% <ø> (ø)
...ts/automl_tests/parallel_tests/test_automl_dask.py 100.0% <ø> (ø)
.../automl_tests/test_automl_search_classification.py 100.0% <ø> (ø)
...data_checks_tests/test_ts_parameters_data_check.py 100.0% <ø> (ø)
...lml/tests/integration_tests/test_nullable_types.py 100.0% <ø> (ø)
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31c88f...6816f2a. Read the comment docs.

@freddyaboulton freddyaboulton changed the title Rename time_index to date_index Rename date_index to time_index Dec 9, 2021
@freddyaboulton freddyaboulton force-pushed the 3074-rename-date-index-time-index branch from b663de0 to 4bc20a1 Compare December 9, 2021 18:27
@freddyaboulton freddyaboulton marked this pull request as ready for review December 9, 2021 19:41
Copy link
Contributor

@bchen1116 bchen1116 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I like that we're changing the name to match ww and make the terms flow with each other

@freddyaboulton freddyaboulton force-pushed the 3074-rename-date-index-time-index branch from 4bc20a1 to c683fb1 Compare December 9, 2021 23:50
Copy link
Contributor

@ParthivNaresh ParthivNaresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@freddyaboulton freddyaboulton merged commit 1392d27 into main Dec 10, 2021
@freddyaboulton freddyaboulton deleted the 3074-rename-date-index-time-index branch December 10, 2021 17:14
@angela97lin angela97lin mentioned this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename date_index to time_index for time series
3 participants