Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 3.9 environment marker for sktime #3332

Merged
merged 6 commits into from
Mar 1, 2022

Conversation

freddyaboulton
Copy link
Contributor

Pull Request Description

Fixes #3322


After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of docs/source/release_notes.rst to include this pull request by adding :pr:123.

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #3332 (656ab21) into main (7b97147) will decrease coverage by 0.7%.
The diff coverage is 100.0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3332     +/-   ##
=======================================
- Coverage   99.6%   99.0%   -0.6%     
=======================================
  Files        329     329             
  Lines      31977   31977             
=======================================
- Hits       31847   31626    -221     
- Misses       130     351    +221     
Impacted Files Coverage Δ
evalml/tests/component_tests/test_utils.py 95.9% <100.0%> (ø)
evalml/tests/pipeline_tests/test_pipelines.py 99.8% <100.0%> (ø)
evalml/tests/utils_tests/test_dependencies.py 85.2% <100.0%> (ø)
evalml/automl/pipeline_search_plots.py 17.9% <0.0%> (-82.1%) ⬇️
...l/tests/automl_tests/test_pipeline_search_plots.py 23.3% <0.0%> (-76.7%) ⬇️
...ests/automl_tests/test_automl_search_regression.py 74.3% <0.0%> (-20.4%) ⬇️
.../automl_tests/test_automl_search_classification.py 83.8% <0.0%> (-12.6%) ⬇️
evalml/tests/automl_tests/test_automl_utils.py 91.1% <0.0%> (-8.9%) ⬇️
...lml/tests/automl_tests/test_iterative_algorithm.py 92.3% <0.0%> (-7.7%) ⬇️
evalml/automl/utils.py 98.5% <0.0%> (-1.5%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b97147...656ab21. Read the comment docs.

@freddyaboulton freddyaboulton force-pushed the 3322-install-sktime-3.9 branch 2 times, most recently from dbd803a to f2261b4 Compare February 17, 2022 22:55
Copy link
Contributor

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freddyaboulton freddyaboulton marked this pull request as ready for review March 1, 2022 16:58
Copy link
Contributor

@angela97lin angela97lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @freddyaboulton! Really cool that we can clean things up 🧹

@@ -5,6 +5,7 @@
* Enhancements
* Fixes
* Changes
* Removed ``python_versrion<3.9`` environment marker from sktime dependency :pr:`3332`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mini typo 😛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

not_supported_in_linux_py39 = set(
["ARIMA Regressor", "Polynomial Detrender", "Exponential Smoothing Regressor"]
)
not_supported_in_linux_py39 = set()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just get rid of this initialization altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep it in case we need to add to it at a later date but I am adding a comment now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM! Hopefully enough time has passed that most packages have added 3.9 support but it's a good structure to keep as a pattern for what we can do in these exception cases :)

@freddyaboulton freddyaboulton enabled auto-merge (squash) March 1, 2022 17:54
@freddyaboulton freddyaboulton merged commit f4a671d into main Mar 1, 2022
@chukarsten chukarsten mentioned this pull request Mar 3, 2022
@freddyaboulton freddyaboulton deleted the 3322-install-sktime-3.9 branch May 13, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install sktime in python 3.9
3 participants