-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3.9 environment marker for sktime #3332
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3332 +/- ##
=======================================
- Coverage 99.6% 99.0% -0.6%
=======================================
Files 329 329
Lines 31977 31977
=======================================
- Hits 31847 31626 -221
- Misses 130 351 +221
Continue to review full report at Codecov.
|
dbd803a
to
f2261b4
Compare
f2261b4
to
ee9681a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @freddyaboulton! Really cool that we can clean things up 🧹
docs/source/release_notes.rst
Outdated
@@ -5,6 +5,7 @@ | |||
* Enhancements | |||
* Fixes | |||
* Changes | |||
* Removed ``python_versrion<3.9`` environment marker from sktime dependency :pr:`3332` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mini typo 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
not_supported_in_linux_py39 = set( | ||
["ARIMA Regressor", "Polynomial Detrender", "Exponential Smoothing Regressor"] | ||
) | ||
not_supported_in_linux_py39 = set() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just get rid of this initialization altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep it in case we need to add to it at a later date but I am adding a comment now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM! Hopefully enough time has passed that most packages have added 3.9 support but it's a good structure to keep as a pattern for what we can do in these exception cases :)
Pull Request Description
Fixes #3322
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rst
to include this pull request by adding :pr:123
.