Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update networkx version #4035

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Update networkx version #4035

merged 5 commits into from
Mar 1, 2023

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Feb 27, 2023

Closes #3972

Networkx changed the topological order of their DAGs with version 2.6, which broke some of our tests that validate the computation order. We pinned it and left it there. Changes here unpin the version and update the tests to be more flexible about the order of computations, so long as the data flow is still maintained.

@eccabay eccabay mentioned this pull request Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #4035 (99f39b2) into main (368384c) will decrease coverage by 15.3%.
The diff coverage is 80.6%.

@@           Coverage Diff            @@
##            main   #4035      +/-   ##
========================================
- Coverage   99.7%   84.4%   -15.3%     
========================================
  Files        349     349              
  Lines      37242   37257      +15     
========================================
- Hits       37121   31425    -5696     
- Misses       121    5832    +5711     
Impacted Files Coverage Δ
...valml/tests/automl_tests/test_default_algorithm.py 0.0% <0.0%> (-100.0%) ⬇️
...valml/tests/pipeline_tests/test_component_graph.py 99.9% <100.0%> (+0.1%) ⬆️
evalml/tests/pipeline_tests/test_pipelines.py 99.9% <100.0%> (ø)
evalml/tests/automl_tests/test_search.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/automl_tests/test_progress.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/tuner_tests/test_skopt_tuner.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/automl_tests/test_engine_base.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/automl_tests/test_automl_utils.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/automl_tests/test_search_iterative.py 0.0% <0.0%> (-100.0%) ⬇️
evalml/tests/tuner_tests/test_grid_search_tuner.py 0.0% <0.0%> (-100.0%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -271,15 +263,11 @@ def test_instantiate_with_parameters(example_graph):
}
component_graph.instantiate(parameters)

expected_order = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the component ordering changing? Just wondering why we're changing these tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that was the change that caused us to pin the version a year and a half ago. For non-linear graphs, the order is now more breadth-first rather than depth-first. It's still a correct ordering, which is why the tests now simply assert that components that must be fit/transformed before others still are.

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gsheni gsheni merged commit c89d114 into main Mar 1, 2023
@gsheni gsheni deleted the 3972_networkx branch March 1, 2023 14:20
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support networkx >=2.6
3 participants