Update networkx version - #4035
Merged
Merged
Conversation
Closed
Codecov Report
@@ Coverage Diff @@
## main #4035 +/- ##
========================================
- Coverage 99.7% 84.4% -15.3%
========================================
Files 349 349
Lines 37242 37257 +15
========================================
- Hits 37121 31425 -5696
- Misses 121 5832 +5711
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eccabay
marked this pull request as ready for review
February 28, 2023 13:13
eccabay
requested review from
christopherbunn,
chukarsten,
jeremyliweishih and
tamargrey
February 28, 2023 13:13
| } | ||
| component_graph.instantiate(parameters) | ||
|
|
||
| expected_order = [ |
Collaborator
There was a problem hiding this comment.
is the component ordering changing? Just wondering why we're changing these tests
Contributor
Author
There was a problem hiding this comment.
Yep, that was the change that caused us to pin the version a year and a half ago. For non-linear graphs, the order is now more breadth-first rather than depth-first. It's still a correct ordering, which is why the tests now simply assert that components that must be fit/transformed before others still are.
gsheni
approved these changes
Feb 28, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3972
Networkx changed the topological order of their DAGs with version 2.6, which broke some of our tests that validate the computation order. We pinned it and left it there. Changes here unpin the version and update the tests to be more flexible about the order of computations, so long as the data flow is still maintained.